From: Jeff King <peff@peff.net>
Date: Sat, 07 Jan 2012 14:55:38 GMT
Subject: Re: [PATCH] credentials: unable to connect to cache daemon
Message-ID: <20120107145538.GC2461@sigill.intra.peff.net>
In-Reply-To: <20120107115434.GA8568@ecki.lan>

On Sat, Jan 07, 2012 at 12:54:36PM +0100, Clemens Buchacher wrote:

> Error out if we just spawned the daemon and yet we cannot connect.

Actually it was intentional not to produce an error. The cache helper is
just a cache, so I consider it "best effort", and if it cannot cache a
password, it's not the end of the world. Git should continue, anyway.

That being said, it's probably nicer to be informative in this case than
not, since it is a configuration error the user probably would like to
fix. And since the rewrite of the credential helper API, it's OK for
helpers to return a failing exit code; git will just ignore it and keep
going.

So I think this is a reasonable thing to do.

Acked-by: Jeff King <peff@peff.net>

> And always release the string buffer.

Oops, thanks.

-Peff