From: Clemens Buchacher Date: Thu, 05 Jan 2012 00:38:41 GMT Subject: Re: [PATCH 1/2] daemon: add tests Message-ID: <20120105003841.GA25285@ecki.lan> In-Reply-To: <7vk457ngi0.fsf@alter.siamese.dyndns.org> On Wed, Jan 04, 2012 at 04:24:23PM -0800, Junio C Hamano wrote: > Clemens Buchacher writes: > > > On Wed, Jan 04, 2012 at 05:26:49PM -0500, Jeff King wrote: > >> > >> Or is the problem the git wrapper itself, which doesn't kill its > >> subprocess when it dies (which IMHO is a bug which we might want to > >> fix)? In that case, couldn't we just use --pid-file to save the actual > >> daemon pid, and then kill using that? > > > > Or like this. Doesn't work with multiple children. I have yet to > > check if we have those anywhere. > > Hmm, don't we have them in the same process group or something, though? > Can't we kill them as a whole? I tried that, but it seems that the test script itself is in the same process group.