From: Jeff King <peff@peff.net>
Date: Fri, 23 Dec 2011 05:47:03 GMT
Subject: Re: [PATCH] attr: map builtin userdiff drivers to well-known extensions
Message-ID: <20111223054703.GA17540@sigill.intra.peff.net>
In-Reply-To: <22866D05066E43DEA0A0EBDF9B7686ED@PhilipOakley>

On Thu, Dec 22, 2011 at 12:05:39AM -0000, Philip Oakley wrote:

> The "*.m=matlab" does give better (proper) hunk headers as it picks
> out the "^%%" comment line which starts a code block . For option 3
> (ObjC) they are empty (which is poor). The plain vanila (default)
> hunk headers are so-so.

Thanks for all of the detail. I think it comes down to the part I
quoted, though: it is indeed a disservice to matlab people to map "*.m"
to objc. So let's be conservative and not do that (projects can always
add their own gitattributes).

(Even before seeing your answer, I dropped it from the re-roll of my
patch that I sent, but this confirms to me that it was the right thing
to do).

-Peff