From: Jeff King <peff@peff.net>
Date: Sat, 17 Dec 2011 12:02:10 GMT
Subject: Re: [BUG] in rev-parse
Message-ID: <20111217120210.GB31152@sigill.intra.peff.net>
In-Reply-To: <4EEA7A7E.4070109@alum.mit.edu>

On Thu, Dec 15, 2011 at 11:53:50PM +0100, Michael Haggerty wrote:

> I believe that the OP was more inconvenienced that "git rev-parse
> --short" chokes on multiple objects than by the fact that it insists
> that the objects exist.  (And shortening the SHA1s of non-existent
> objects doesn't sound very useful anyway.)  So I think that a useful
> compromise would be for "git rev-parse --short" to accept multiple args
> but continue to insist that each of the args is a valid object.

Part of the guarantee of "--verify" is that it returns a single object.
I don't know how many callers rely on "--short" implying "--verify"
implying a single object.

I agree in practice it would probably be an OK change, and it's very
easy to do. I just don't think it's an important enough problem to worry
about, given the available workaround. But if you want to write the
patch, be my guest. :)

-Peff