From: Jeff King <peff@peff.net>
Date: Wed, 14 Dec 2011 07:17:55 GMT
Subject: Re: [PATCH resend] Do not create commits whose message contains NUL
Message-ID: <20111214071755.GA19945@sigill.intra.peff.net>
In-Reply-To: <buomxavwwtq.fsf@dhlpc061.dev.necel.com>

On Wed, Dec 14, 2011 at 02:23:29PM +0900, Miles Bader wrote:

> Jeff King <peff@peff.net> writes:
> >      But maybe it would be nicer to say something like:
> >
> >        error: your commit message contains NUL characters.
> >        hint: This is often caused by using multibyte encodings such as
> >        hint: UTF-16. Please check your editor settings.
> 
> I think the error message with the hint is much better for users, but
> isn't the term "multibyte" a little misleading here?  It seems like
> it's really _wide_ encodings that are generally the culprit.

Yeah, wide is probably a better term. I'm not sure it is rigorously
defined anywhere, but in general I think it refers to the set of
encodings that do not care about the embedding of 8-bit ascii bytes as
subsets.

-Peff