From: Jeff King <peff@peff.net>
Date: Tue, 13 Dec 2011 00:58:12 GMT
Subject: Re: [PATCH 2/2] Makefile: optionally exclude code that needs Unix sockets
Message-ID: <20111213005812.GA3947@sigill.intra.peff.net>
In-Reply-To: <7vzkexwb7m.fsf@alter.siamese.dyndns.org>

On Mon, Dec 12, 2011 at 03:31:44PM -0800, Junio C Hamano wrote:

> > In theory we should also disable the documentation for credential-cache.
> > But that means surgery not only to Documentation/Makefile, but figuring
> > out how to pass the flags down to the actual asciidoc process (since
> > gitcredentials(7) mentions it in the text). Certainly possible, but I
> > don't know if it's worth the effort or not.
> 
> I do not think it matters that much. We've been shipping documentation for
> stuff like remote archiver and daemon without conditional compilation, no?

True. Let's not worry about it, then.

> I'll queue a single patch that is a squash between 2/2 and Peff's test
> updates between "credentials: add "cache" helper" and "strbuf: add
> strbuf_add*_urlencode" in the series.

That's perfect. Thanks.

-Peff