From: Jeff King Date: Mon, 12 Dec 2011 21:52:39 GMT Subject: Re: [PATCH 4/5] mv: improve overwrite warning Message-ID: <20111212215238.GD9754@sigill.intra.peff.net> In-Reply-To: <7vobvd36ms.fsf@alter.siamese.dyndns.org> On Mon, Dec 12, 2011 at 11:57:31AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > This message looks overly long to me, but I wanted to match the existing > > messages. Another option would be just: > > > > warning: overwriting 'three/one' > > Yes, I think it makes perfect sense to drop the ugly "source=one destination=two" > cruft, both for single-source and multiple-source cases. Yeah, the more I look at the message in the patch I sent, the uglier it gets. Here's a re-rolled 4 and 5 with the nicer format. -Peff