From: Jeff King Date: Sat, 10 Dec 2011 10:39:44 GMT Subject: [PATCHv2 0/9] echo characters in username prompt Message-ID: <20111210103943.GA16478@sigill.intra.peff.net> In-Reply-To: <20111210102827.GA16460@sigill.intra.peff.net> On Sat, Dec 10, 2011 at 05:28:27AM -0500, Jeff King wrote: > Here's the latest re-roll of the credential helpers series. I think this > one is probably ready to go to 'next'. And here's the prompt/terminal refactoring to go on top of it. This isn't as well reviewed as the main credential series, but I think it's reasonably solid. Since the last round, I fixed the bone-head NO_DEV_TTY/HAVE_DEV_TTY mixup that Jakub pointed out. And I split the "Linux has /dev/tty" patch out so I could test to make sure it isn't accidentally turned on until we actually enable it. I also tested it on OS X, and it works fine there. [1/9]: imap-send: avoid buffer overflow [2/9]: imap-send: don't check return value of git_getpass [3/9]: move git_getpass to its own source file [4/9]: refactor git_getpass into generic prompt function [5/9]: add generic terminal prompt function [6/9]: prompt: use git_terminal_prompt [7/9]: credential: use git_prompt instead of git_getpass [8/9]: Makefile: linux has /dev/tty [9/9]: Makefile: OS X has /dev/tty -Peff