From: Jeff King <peff@peff.net>
Date: Fri, 09 Dec 2011 23:19:09 GMT
Subject: Re: [PATCHv2 12/13] credentials: add "store" helper
Message-ID: <20111209231909.GA14526@sigill.intra.peff.net>
In-Reply-To: <20111206062305.GL29233@sigill.intra.peff.net>

On Tue, Dec 06, 2011 at 01:23:05AM -0500, Jeff King wrote:

> +int main(int argc, const char **argv)
> +{
> +	const char * const usage[] = {
> +		"git credential-store [options] <action>",
> +		NULL
> +	};
> +	const char *op;
> +	struct credential c = CREDENTIAL_INIT;
> +	char *file = NULL;
> +	struct option options[] = {
> +		OPT_STRING_LIST(0, "file", &file, "path",
> +				"fetch and store credentials in <path>"),
> +		OPT_END()
> +	};

Eek, this should be OPT_STRING, of course. I'll fix it in my next
re-roll, but I wanted to mention it in case anybody is reviewing v2.

-Peff