From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 08 Dec 2011 17:18:05 GMT
Subject: Re: [PATCH 6/6] test: fix '&&' chaining
Message-ID: <20111208171805.GG2394@elie.hsd1.il.comcast.net>
In-Reply-To: <1323349817-15737-9-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> Breaks in a test assertion's && chain can potentially hide failures
> from earlier commands in the chain.  Fix instances of this in the
> following tests:
> 
> t3419 (rebase-patch-id)
> t3310 (notes-merge-manual-resolve)
[...]

The reader can read the diffstat, so I am not sure this list is very
useful.

With the space gained, it might be helpful to mention that this patch
only adds " &&" to the ends of lines and that any other kind of change
here would be unintentional, to put the reader's mind at ease.

[...]
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>

The patch proper looks good, so if this is tested,
Acked-by: Jonathan Nieder <jrnieder@gmail.com>