From: Jonathan Nieder Date: Thu, 08 Dec 2011 17:07:16 GMT Subject: Re: [PATCH 4/6] t3200 (branch): fix '&&' chaining Message-ID: <20111208170716.GE2394@elie.hsd1.il.comcast.net> In-Reply-To: <1323349817-15737-7-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra wrote: > Breaks in a test assertion's && chain can potentially hide failures > from earlier commands in the chain. Fix these breaks. > > Additionally, note that 'git branch --help' will fail when git This is not "Additionally, while we're here" but rather "In order to do so". > manpages aren't already installed: guard the line with a > 'test_might_fail'. > > Signed-off-by: Ramkumar Ramachandra > --- > t/t3200-branch.sh | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) For what it's worth, Acked-by: Jonathan Nieder