From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 08 Dec 2011 16:34:48 GMT
Subject: Re: [PATCH 1/6] t3040 (subprojects-basic): modernize style
Message-ID: <20111208163448.GA2394@elie.hsd1.il.comcast.net>
In-Reply-To: <1323349817-15737-3-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> Put the opening quote starting each test on the same line as the
> test_expect_* invocation.  While at it:

I suspect the above description, while it does describe your patch,
does not describe the _reason_ that the patch exists or that someone
would want to apply it.  Isn't it something more like:

	Make the following changes pertaining to &&-chaining, for some
	good reason that I will describe:

	- ...

	While at it, clean up the style to fit the prevailing style.
	That means:

	- Put the opening quote starting each test on the same line as
	...

I didn't read over the patch again.  Has it changed since v1?