From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 08 Dec 2011 16:30:50 GMT
Subject: Re: [PATCH 1/2] parse-options: introduce OPT_SUBCOMMAND
Message-ID: <20111208163049.GA2116@elie.hsd1.il.comcast.net>
In-Reply-To: <1323349817-15737-2-git-send-email-artagnon@gmail.com>

Hi,

Quick thoughts:

Ramkumar Ramachandra wrote:

> Currently, the parse-options framework forbids the use of
> opts->long_name and OPT_PARSE_NODASH, and the parsing has to be done
> by hand as a result.  Lift this restriction

This part seems like a sane idea to me.

> , and create a new
> OPT_SUBCOMMAND; this is built on top of OPTION_BIT to allow for the
> detection of more than one subcommand.

This part I am not convinced about.  Usually each subcommand takes its
own options, so I cannot see this OPT_SUBCOMMAND being actually useful
for commands like "git stash" or "git remote".

Hope that helps,
Jonathan