From: Jeff King <peff@peff.net>
Date: Wed, 07 Dec 2011 23:10:03 GMT
Subject: Re: [PATCH 1/4] test: add missing "&&" after echo command
Message-ID: <20111207231002.GD21852@sigill.intra.peff.net>
In-Reply-To: <20111207144540.GB30157@elie.hsd1.il.comcast.net>

On Wed, Dec 07, 2011 at 08:45:40AM -0600, Jonathan Nieder wrote:

> diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> index 3ad04363..da75abc1 100755
> --- a/t/t7501-commit.sh
> +++ b/t/t7501-commit.sh
> @@ -60,7 +60,7 @@ test_expect_success \
>  
>  test_expect_success \
>  	"next commit" \
> -	"echo 'bongo bongo bongo' >file \
> +	"echo 'bongo bongo bongo' >file && \
>  	 git commit -m next -a"

Patch is obviously correct, but isn't the "\" here just superfluous and
error-prone? Maybe it should just be dropped from the new version (and
possibly from other tests in t7501).

-Peff