From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 07 Dec 2011 21:51:00 GMT
Subject: Re: [PATCH 07/15] t1510 (worktree): fix && chaining
Message-ID: <20111207215100.GB2911@elie.hsd1.il.comcast.net>
In-Reply-To: <1323286611-4806-8-git-send-email-artagnon@gmail.com>

Patches 5 and 6 look safe, though I haven't tested them.

Ramkumar Ramachandra wrote:

> --- a/t/t1501-worktree.sh
> +++ b/t/t1501-worktree.sh
> @@ -48,7 +48,7 @@ test_expect_success 'setup: helper for testing rev-parse' '
>  '
>  
>  test_expect_success 'setup: core.worktree = relative path' '
> -	unset GIT_WORK_TREE;
> +	unset GIT_WORK_TREE &&

On some shells, like /usr/xpg4/bin/sh on Solaris, unset returns nonzero
status when the variable passed was already unset.  Will this work on
such platforms, or does it need to be changed to use sane_unset?