From: Jonathan Nieder Date: Wed, 07 Dec 2011 14:42:17 GMT Subject: [PATCH/RFC 0/4] Re: commit: honor --no-edit Message-ID: <20111207144217.GA30157@elie.hsd1.il.comcast.net> In-Reply-To: <7vk469fm9j.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > And this should fix it (only lightly tested). > > -- >8 -- > Subject: [PATCH] commit: honor --no-edit > > After making fixes to the contents to be committed, it is not unusual to > update the current commit without rewording the message. Idioms to do > tell "commit --amend" that we do not need an editor have been: > > $ EDITOR=: git commit --amend > $ git commit --amend -C HEAD > > but that was only because a more natural > > $ git commit --amend --no-edit > > did not honour "--no-edit" option. I like it. Here are a couple of tests. The three patches before are just to make it less frightening to add to the relevant test script. Jonathan Nieder (4): test: add missing "&&" after echo command test: remove a test of porcelain that hardcodes commit ids t7501 (commit): modernize style test: commit --amend should honor --no-edit t/t7501-commit.sh | 335 ++++++++++++++++++++++++++++------------------------- 1 files changed, 175 insertions(+), 160 deletions(-)