From: Jonathan Nieder Date: Wed, 07 Dec 2011 07:06:27 GMT Subject: Re: [PATCH 3/5] revert: simplify getting commit subject in format_todo() Message-ID: <20111207070627.GD11737@elie.hsd1.il.comcast.net> In-Reply-To: <1323239877-24101-4-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra wrote: > format_todo() calls get_message(), but uses only the subject line of > the commit message. Save work and unnecessary memory allocations by > using find_commit_subject() instead. Also, remove the spurious check > on cur->item: the previous patch makes sure that instruction sheets > with missing commit subjects are parsable. So, what effect will this patch actually have? Is it an optimization with no other observable effect?