From: Jeff King <peff@peff.net>
Date: Fri, 18 Nov 2011 10:33:55 GMT
Subject: Re: [PATCH] receive-pack, fetch-pack: reject bogus pack that records objects twice
Message-ID: <20111118103355.GA4854@sigill.intra.peff.net>
In-Reply-To: <7v7h2znv36.fsf@alter.siamese.dyndns.org>

On Wed, Nov 16, 2011 at 10:04:13PM -0800, Junio C Hamano wrote:

> When receive-pack & fetch-pack are run and store the pack obtained over
> the wire to a local repository, they internally run the index-pack command
> with the --strict option. Make sure that we reject incoming packfile that
> records objects twice to avoid spreading such a damage.

If we are fixing a thin pack (which should be the case most of the
time), we are rewriting the packfile anyway. Shouldn't we just omit
the duplicate?

I guess I'm a little confused about what is generating these duplicates.
A buggy git? A malicious server? Bad luck?

-Peff