From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 18 Nov 2011 01:36:13 GMT
Subject: Re: [PATCH 8/8] Enable GIT_DEBUG_MEMCHECK on git_pathname()
Message-ID: <20111118013613.GB22485@elie.hsd1.il.comcast.net>
In-Reply-To: <20111118012715.GA7826@sigill.intra.peff.net>

Jeff King wrote:
> On Fri, Nov 18, 2011 at 08:12:27AM +0700, Nguyen Thai Ngoc Duy wrote:

>> notes-merge.c introduces __VA_ARGS__ since v1.7.4 so we may want to do
>> something there too.
>
> I hadn't noticed. That definitely violates our usual rules about
> portability.  That usage can easily be turned into an inline function.
> However, since nobody has complained in the past year, it makes me
> wonder if we are overly conservative (my guess is that people on crazy
> old compilers just don't keep up with git. Which maybe means they aren't
> worth worrying about. But who knows).

I suspect we didn't notice because MSVC 2005 and later have some
(limited, as far as I can tell from web searches) support for
__VA_ARGS__.