From: Jeff King <peff@peff.net>
Date: Fri, 04 Nov 2011 17:51:27 GMT
Subject: Re: [PATCH v3 2/3] http.c: Use timeout suggested by curl instead of fixed 50ms timeout
Message-ID: <20111104175127.GA26118@sigill.intra.peff.net>
In-Reply-To: <CAOs=hRKxc9SdE_HTnfs+WdnxZEY6yF9MBV_K1FX2=7B7xtj7-w@mail.gmail.com>

On Fri, Nov 04, 2011 at 06:47:44PM +0100, Mika Fischer wrote:

> >                if (slot->in_use && !data_received) {
> >  #if LIBCURL_VERSION_NUM >= 0x070f04
> > +                       long curl_timeout;
> >                        curl_multi_timeout(curlm, &curl_timeout);
> >                        if (curl_timeout == 0) {
> >                                continue;
> 
> Ah yes, that's good. I would have done it this way in C++, but I
> wasn't sure whether C99 is OK for git.

C99 is not OK. But this is not C99, as the conditional opens a new
block.

-Peff