From: Jakub Narebski <jnareb@gmail.com>
Date: Wed, 26 Oct 2011 00:36:58 GMT
Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
Message-ID: <201110260236.59509.jnareb@gmail.com>
In-Reply-To: <1319583484.10399.41.camel@drew-northup.unet.maine.edu>

Drew Northup napisał:
> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
> > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> > ---
> >  gitweb/Makefile |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/gitweb/Makefile b/gitweb/Makefile
> > index 1c85b5f..4191c6b 100644
> > --- a/gitweb/Makefile
> > +++ b/gitweb/Makefile
> > @@ -185,7 +185,9 @@ install: all
> >  ### Cleaning rules
> >  
> >  clean:
> > -	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
> > +	$(RM) gitweb.cgi static/gitweb.js \
> > +		static/gitweb.min.js static/gitweb.min.css \
> > +		GITWEB-BUILD-OPTIONS
> >  
> >  .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
> >  
> 
> Forgive me for sounding a bit numb, but what does this fix? I don't see
> it in the commit message.

gitweb.js is nowadays a generated file.  Though that bit should be
in commit message...

-- 
Jakub Narebski
Poland