From: Jeff King Date: Sun, 23 Oct 2011 16:09:15 GMT Subject: Re: [PATCH 00/22] Refactor to accept NUL in commit messages Message-ID: <20111023160914.GB22444@sigill.intra.peff.net> In-Reply-To: <4EA3F00E.9040006@gmail.com> On Sun, Oct 23, 2011 at 12:44:30PM +0200, Robin Rosenberg wrote: > Jeff King skrev 2011-10-22 21.09: > >On Sat, Oct 22, 2011 at 09:04:19PM +1100, Nguyen Thai Ngoc Duy wrote: > > > >>This series helps pass commit message size up to output functions, > >>though it does not change any output functions to print ^@. > >Can we take a step back for a second and discuss what git _should_ do > >with commits that contain NUL? > Yes please. I don't think allowing NUL makes sense, but it makes sense > to state how NUL should be handled when anyone attempt it, so there > might be things to fix even if NUL is banned. > > Are there any such commits in the wild? Adding an arbitrary NUL, no, I don't think I've ever seen it outside of people (myself included) trying to break git in interesting ways. But utf16 may contains NUL bytes, so I expect configuring your editor to output utf16 and running "git commit" would give you the most likely example. -Peff