From: Jonathan Nieder Date: Thu, 20 Oct 2011 08:03:28 GMT Subject: Re: [PATCH 3/6] revert: fix buffer overflow in insn sheet parser Message-ID: <20111020080328.GA12337@elie.hsd1.il.comcast.net> In-Reply-To: <7v8vogbgai.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Ramkumar Ramachandra writes: >> Check that the commit name argument to a "pick" or "revert" action in >> '.git/sequencer/todo' is not too long [...] > Given that this function is going to be fixed properly so that it does not > even need to use the "on-stack buffer", is this really necessary? Right, I don't think it is. Keeping a testcase sounds worthwhile, though.