From: Peter Stuge <peter@stuge.se>
Date: Mon, 26 Sep 2011 22:28:01 GMT
Subject: Re: [PATCH] gitweb: Add js=1 before an URI fragment to fix line number links
Message-ID: <20110926222801.14985.qmail@stuge.se>
In-Reply-To: <7vipof0zx0.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> > I thought subject together with change would be clear enough. :)
> >
> >
> >> Explanation of what you are fixing is totally lacking.
> >
> > The subject sums it up, if briefly.
> 
> ... Sorry, that is not what I meant.
> 
> You don't have to explain these to *me* specifically as a response
> to this thread. What I meant was that your patch should have these
> necessary descriptions in its proposed commit log message.

IMO not so neccessary if one knows a little web and javascript, which
is probably likely for a gitweb change..

It's a simple fix of links broken by manual URI manipulation that
didn't consider fragments. Is the subject description really not
enough?


//Peter