From: Jeff King <peff@peff.net>
Date: Mon, 19 Sep 2011 18:20:49 GMT
Subject: Re: [PATCH] git-web--browse: invoke kfmclient directly
Message-ID: <20110919182049.GA26115@sigill.intra.peff.net>
In-Reply-To: <7vvcso9zzi.fsf@alter.siamese.dyndns.org>

On Mon, Sep 19, 2011 at 10:57:37AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > Hmm. Actually, the one for custom browser commands might need it,
> > because that one is expected to be a shell snippet. I suspect the
> > simplest thing is to do something like:
> >
> >   eval "$browser_cmd \"\$@\""
> 
> Yeah, I agree, and the dq around $browser_cmd is kind of important, too,
> for that to work and be readable.

Oops, good catch. Probably the most readable version would be:

  eval "\"$browser_cmd\"" '"$@"'

-Peff