From: Jonathan Nieder Date: Sun, 18 Sep 2011 21:30:50 GMT Subject: Re: [PATCH/RFC 0/2] fast-import: commit from null_sha1 Message-ID: <20110918213050.GJ2308@elie> In-Reply-To: <1316380846-15845-1-git-send-email-divanorama@gmail.com> Dmitry Ivankov wrote: > These patches make fast-import treat > commit refs/heads/master > ... > from `null_sha1` > like any other missing parent sha1 - reject such input. Are you sure the existing support for "from 0{40}" is not deliberate and that no one is relying on it? If and only if you are, then this seems like a good idea (a single patch that both makes the behavior change and adds a test for it should be easier to review).