From: Michał Górny Date: Thu, 15 Sep 2011 08:18:15 GMT Subject: Re: [PATCH] for-each-ref: add split message parts to %(contents:*). Message-ID: <20110915101815.172fb47a@pomiocik.lan> In-Reply-To: <20110907174044.GA11341@sigill.intra.peff.net> On Wed, 7 Sep 2011 13:40:44 -0400 Jeff King wrote: > On Fri, Sep 02, 2011 at 01:53:23PM -0400, Jeff King wrote: > > > But there may be other corner cases. I need to read through the > > code more carefully, which I should have time to do later today. > > This ended up a little trickier than I expected, but I think the > series below is what we should do. I tried to add extensive tests, > but let me know if you can think of any other corner cases. > > [1/5]: t7004: factor out gpg setup > [2/5]: t6300: add more body-parsing tests > [3/5]: for-each-ref: refactor subject and body placeholder parsing > [4/5]: for-each-ref: handle multiline subjects like --pretty > [5/5]: for-each-ref: add split message parts to %(contents:*). Thanks, it works great for me. I tried multi-line subject + signature too and that works fine. -- Best regards, Michał Górny