From: Jeff King <peff@peff.net>
Date: Tue, 06 Sep 2011 20:24:40 GMT
Subject: Re: [PATCH] date.c: Parse timezone with colon as separator
Message-ID: <20110906202440.GD14554@sigill.intra.peff.net>
In-Reply-To: <1315320996-1997-1-git-send-email-lihaitao@gmail.com>

On Tue, Sep 06, 2011 at 10:56:36PM +0800, Haitao Li wrote:

> Timezone designators including additional separator (`:`) are ignored.
> Actually zone designators in below formats are all valid according to
> ISO8601:2004, section 4.3.2:
>     [+-]hh, [+-]hhmm, [+-]hh:mm

That seems like a sensible list to support, given that it is part of
iso8601 (though I was a little surprised after reading your subject
line, which would probably be better as "support iso8601 timezone
formats").

> ---
>  date.c |   14 ++++++++++----
>  1 files changed, 10 insertions(+), 4 deletions(-)

We should probably have new tests, too. I was going to suggest squashing
in the ones below, but your patch doesn't seem to work with the first
one:

diff --git a/t/t0006-date.sh b/t/t0006-date.sh
index f87abb5..9b326cd 100755
--- a/t/t0006-date.sh
+++ b/t/t0006-date.sh
@@ -40,6 +40,8 @@ check_parse 2008-02 bad
 check_parse 2008-02-14 bad
 check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 +0000'
 check_parse '2008-02-14 20:30:45 -0500' '2008-02-14 20:30:45 -0500'
+check_parse '2008-02-14 20:30:45 -05' '2008-02-14 20:30:45 -0500'
+check_parse '2008-02-14 20:30:45 -05:00' '2008-02-14 20:30:45 -0500'
 check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 -0500' EST5
 
 check_approxidate() {

If I am reading your commit message correctly, that should work, right?

-Peff