From: Michał Górny <mgorny@gentoo.org>
Date: Thu, 01 Sep 2011 07:34:50 GMT
Subject: Re: [PATCH] for-each-ref: add split message parts to %(contents:*).
Message-ID: <20110901093450.57512480@pomiocik.lan>
In-Reply-To: <20110831232201.GA29296@sigill.intra.peff.net>

On Wed, 31 Aug 2011 19:22:01 -0400
Jeff King <peff@peff.net> wrote:

> On Wed, Aug 31, 2011 at 03:54:35PM -0700, Junio C Hamano wrote:
> 
> > > +The complete message in a commit and tag object is `contents`.
> > > +Its first line is `contents:subject`, the remaining lines
> > > +are `contents:body` and the optional GPG signature
> > > +is `contents:signature`.
> > 
> > To match the parsing of commit objects, I would prefer to see
> > "subject" to mean "the first paragraph" (usually the first line
> > alone but that is purely from convention), but that probably is a
> > separate topic.
> 
> Good idea. I suspect pretty.c:format_subject can be reused here.

Should I fix regular 'subject' and 'body' as well, or just
the 'contents:' variants?

-- 
Best regards,
Michał Górny