From: Michał Górny <mgorny@gentoo.org>
Date: Tue, 30 Aug 2011 15:58:43 GMT
Subject: Re: [PATCH] git-for-each-ref: move GPG sigs off %(body) to %(signature).
Message-ID: <20110830175843.24ee6c1d@pomiocik.lan>
In-Reply-To: <4E5CB0D0.7000905@drmicha.warpmail.net>

On Tue, 30 Aug 2011 11:43:44 +0200
Michael J Gruber <git@drmicha.warpmail.net> wrote:

> > When grabbing a %(body) or %(contents) off a tag, one doesn't really
> > expect to get the GPG signature as well (as it's basically useless
> > without the complete signed text). Thus, strip it off those two
> > tags, and make available via %(signature) if anyone needs it.
> 
> No, please do not change %(contents). It is the complete content which
> (together with the header) enters into the sha1 calculation.
> 
> You will probably also face opposition as regards to %(body), changing
> existing behaviour.
> 
> In fact, I wish we didn't have %(body) but %(contents:body) just like
> other modifiers such as :short.

Yeah, I was wondering why it is like that.

> I think I'd go for
> 
> %(contents:signature)
> 
> and implement
> 
> %(contents:subject) the same as %(subject)
> %(contents:body) as contents minus subject minus signature

How should I implement the ':' magic? Through adding a new type or just
putting ':' in place?

-- 
Best regards,
Michał Górny