From: Thomas Rast <trast@student.ethz.ch>
Date: Fri, 26 Aug 2011 09:44:35 GMT
Subject: Re: [RFC/PATCH] attr: map builtin userdiff drivers to well-known extensions
Message-ID: <201108261144.35888.trast@student.ethz.ch>
In-Reply-To: <20110825204047.GA9948@sigill.intra.peff.net>

Jeff King wrote:
> We already provide sane hunk-header patterns for specific
> languages. However, the user has to manually map common
> extensions to use them. It's not that hard to do, but it's
> an extra step that the user might not even know is an
> option. Let's be nice and do it automatically.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I tried to think of negative side effects.
> 
> The userdiff drivers we have are pretty conservative; they just specify
> hunk headers.

And word-diff regexes.

In my book this is a plus for your patch, but I'm just saying.  It
will trigger the slightly slower mode of word-diffing that splits at
far more places than the default.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch