From: Jeff King <peff@peff.net>
Date: Wed, 24 Aug 2011 20:20:27 GMT
Subject: Re: [PATCH] rebase -i: clean error message for --continue after failed exec
Message-ID: <20110824202027.GA28900@sigill.intra.peff.net>
In-Reply-To: <7v62lmps6k.fsf@alter.siamese.dyndns.org>

On Wed, Aug 24, 2011 at 11:42:27AM -0700, Junio C Hamano wrote:

> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> 
> > If after a failed "exec" instruction there are staged changes,...
> 
> I have to wonder why whatever "exec" runs is mucking with the index in the
> first place. Shouldn't we forbid it?

Certainly my only user has ever been "exec make test". But I wonder if
somebody is crazy enough to auto-generate some content and commit it.
OTOH, shouldn't it then be their responsibility to make the commit?
I.e., I can see at least the potential for mucking with the index, but I
really don't see a reason for _leaving_ the index in a mucked state.

-Peff