From: Jeff King Date: Mon, 22 Aug 2011 21:32:14 GMT Subject: Re: Malformed branch name in fast-export when specifying non-HEAD/branch revision Message-ID: <20110822213214.GA14404@sigill.intra.peff.net> In-Reply-To: <7vpqjxuogr.fsf@alter.siamese.dyndns.org> On Mon, Aug 22, 2011 at 02:27:00PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Yeah, the behavior of your patch looks fine to me. I thought the point > > in contention was that having export understand refspecs would fix a lot > > of _other_ cases, too. > > Perhaps if we added refspecs we could cover other cases, too, but I do not > think we need to require the patch to cover additional cases. The more > problematic was that the particular implementation in the patch smelled > bad. OK. I didn't look at that at all. I just wanted to express my support for "refspecs would solve other problems, too". :) -Peff