From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 14 Aug 2011 16:15:52 GMT
Subject: Re: [PATCH 1/7] revert: Free memory after get_message call
Message-ID: <20110814161552.GM18466@elie.gateway.2wire.net>
In-Reply-To: <1313310789-10216-2-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> The format_todo function leaks memory because it forgets to call
> free_message after get_message.  It is a potentially big leak, because
> fresh memory is allocated to store the commit message message for each
> commit.  Fix this.

Reading this, I think, "why does formatting an insn list require all
these heavy memory allocations?".  So while the patch looks good to
me, I start to wonder if something using find_commit_subject()
directly would not be easier.