From: Jonathan Nieder Date: Thu, 11 Aug 2011 20:16:04 GMT Subject: Re: [PATCH 5/6] sequencer: Expose API to cherry-picking machinery Message-ID: <20110811201604.GI2277@elie.gateway.2wire.net> In-Reply-To: <1313088705-32222-6-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra wrote: > --- a/sequencer.h > +++ b/sequencer.h > @@ -7,7 +7,32 @@ > #define SEQ_TODO_FILE "sequencer/todo" > #define SEQ_OPTS_FILE "sequencer/opts" > > +#define COMMIT_MESSAGE_INIT { NULL, NULL, NULL, NULL, NULL }; I don't think this should be exposed. The rest seems pretty sane, though I haven't read the patch carefully.