From: Christian Couder <chriscool@tuxfamily.org>
Date: Wed, 03 Aug 2011 05:27:03 GMT
Subject: Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain.
Message-ID: <201108030727.04246.chriscool@tuxfamily.org>
In-Reply-To: <CAH3AnrrkAeN3BgnnFBsbzh=37tC6f6aRACgk94wxW85qFQpfVw@mail.gmail.com>

On Tuesday 02 August 2011 16:41:13 Jon Seymour wrote:
> On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder
> 
> <christian.couder@gmail.com> wrote:
> > On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> >> @@ -34,6 +34,8 @@ require_work_tree
> >>  _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
> >>  _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
> >> 
> >> +BISECT_MODE=$(test -f "$GIT_DIR/BISECT_MODE" && cat
> >> "$GIT_DIR/BISECT_MODE")
> > 
> > Could you put this line just where it is needed, that is in
> > bisect_next() and bisect_reset()?
> 
> Ultimately, it is also needed in paths that call bisect_state(), such
> as bisect_run() and bisect_skip() so I am not keen to do this.
>
> If I was to do this, I'd prefer to change uses of $BISECT_MODE with a
> call to a function bisect_mode() that does the same thing.

Yeah, I think it would be a good idea to have a bisect_mode() function.
I don't like very much to blindly call some code when we might not need it.

Thanks,
Christian.