From: Clemens Buchacher <drizzd@aon.at>
Date: Sat, 30 Jul 2011 16:22:59 GMT
Subject: Re: [PATCH] Break down no-lstat() condition checks in verify_uptodate()
Message-ID: <20110730162258.GC7545@toss.lan>
In-Reply-To: <1311998105-6267-1-git-send-email-pclouds@gmail.com>

On Sat, Jul 30, 2011 at 10:55:05AM +0700, Nguyễn Thái Ngọc Duy wrote:
>
> +	/*
> +	 * CE_VALID and CE_SKIP_WORKTREE cheat, we better check again
> +	 * if this entry is truely uptodate because this file may be
> +	 * overwritten.
> +	 */

s/truely/truly

> +	if ((ce->ce_flags & CE_VALID) || ce_skip_worktree(ce))
> +		; /* keep checking */
> +	else if (o->reset || ce_uptodate(ce))
>  		return 0;

Nice! Acked-by: Clemens Buchacher <drizzd@aon.at>