From: Jonathan Nieder Date: Wed, 27 Jul 2011 04:46:51 GMT Subject: Re: [PATCH 10/18] revert: Don't create invalid replay_opts in parse_args Message-ID: <20110727044651.GF18470@elie> In-Reply-To: <1311736755-24205-11-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra wrote: > To futureproof > the code and catch these errors in one place, make sure that an > invalid replay_opts structure is not created by parse_args in the > first place. FWIW, patches 8-10 all have reasonable goals and look like they address them in a sane way from a quick glance.