From: Jeff King <peff@peff.net>
Date: Fri, 22 Jul 2011 22:16:04 GMT
Subject: Re: [PATCH 06/14] introduce credentials API
Message-ID: <20110722221602.GB14118@sigill.intra.peff.net>
In-Reply-To: <7vtyaevupu.fsf@alter.siamese.dyndns.org>

On Fri, Jul 22, 2011 at 02:42:09PM -0700, Junio C Hamano wrote:

> >> The document did not say anything about escaping/quoting of values, but it
> >> may not be a bad idea to make it more explicit over there.
> >
> > There is no quoting or escaping. As the document says, "the value may
> > contain any bytes except a newline". It doesn't mention that keys cannot
> > contain an "=" or a newline, though that is also true.
> 
> This also was a documentation comment; "may contain any bytes" can be
> followed with "and used as-is" and I wouldn't have been confused.

Makes sense. I'll tweak for the next version.

-Peff