From: Jeff King <peff@peff.net>
Date: Fri, 22 Jul 2011 20:40:07 GMT
Subject: Re: [PATCH 06/14] introduce credentials API
Message-ID: <20110722204007.GB11922@sigill.intra.peff.net>
In-Reply-To: <7vvcuvz458.fsf@alter.siamese.dyndns.org>

On Thu, Jul 21, 2011 at 02:59:31PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > diff --git a/credential.c b/credential.c
> > new file mode 100644
> > index 0000000..c403289
> > --- /dev/null
> > +++ b/credential.c
> > @@ -0,0 +1,190 @@
> > ...
> > +void credential_fill(struct credential *c, const struct string_list *methods)
> > +{
> > +	...
> > +	}
> > +	die(err.buf);
> 
> credential.c:195: error: format not a string literal and no format arguments
> 
> This needs to be
> 
> 	die("%s", err.buf);

Thanks, silly me. I'm surprised I didn't get a warning, as I compile
with -Wall. Is there an extra flag you need to give gcc?

-Peff