From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 06 Jul 2011 10:03:31 GMT
Subject: Re: [PATCH 01/14] advice: Introduce error_resolve_conflict
Message-ID: <20110706100331.GH15682@elie>
In-Reply-To: <CALkWK0k57L5vc7oVQKw=G9FXtYkmnp8QaWrW_p1CvupyNGofZg@mail.gmail.com>

Ramkumar Ramachandra wrote:

> Yes, but I was worried that I shouldn't expose it because your commit
> message (2a41df) says:
>
>     It is local to revert.c for now because I am not sure this is
>     the right API (we may want to take an array of advice lines or a
>     boolean argument for easy suppression of unwanted advice).
>
> So, is it still alright to expose it in advice.h?

Well, presumably this second caller is evidence that it is the right
API, no? :)

Of course the API can still easily be changed later.