From: Jonathan Nieder Date: Sat, 02 Jul 2011 11:30:08 GMT Subject: Re: [PATCH 09/13] revert: Catch incompatible command-line options early Message-ID: <20110702113008.GA21526@elie> In-Reply-To: Ramkumar Ramachandra wrote: > Although pick_commits checks the validity of the > replay_opts strucutre before before starting its operation, this is > fragile design because the validity of the replay_opts structure > depends on pick_commits being called before anything else. Thanks, that's a bit more concrete. But it's not fragile, is it? pick_commits() is the entry point to the cherry-pick machinery --- anything that uses a struct replay_opts is called indirectly by pick_commits(), no? So (genuinely, even when I'm not pretending to be naive) I still don't see the point. I'm not even convinced it's a bad idea, since it's still not clear to me what the idea is.