From: Fredrik Gustafsson <iveqy@iveqy.com>
Date: Tue, 28 Jun 2011 21:59:31 GMT
Subject: Re: [RFC 2/2] Don't push a repository with unpushed submodules
Message-ID: <20110628215931.GA3974@paksenarrion.iveqy.com>
In-Reply-To: <7viprpu1p5.fsf@alter.siamese.dyndns.org>

On Tue, Jun 28, 2011 at 01:43:18PM -0700, Junio C Hamano wrote:
> > This check is solely meant as a convenience security measure. It should
> > and can not enforce a tight check whether a superproject (including its
> > submodules) can be cloned/checked out at all times. But it ensures that
> > a developer has pushed his submodule commits "somewhere" which is enough
> > in practice.
> 
> I am not entirely convinced but if this would catch more than 80% of
> casual mistakes, it would be good enough.  I was hoping that somebody may
> come up with an idea that would work even in case (3), though.
> 

There's ways to do a "better" check, but only(*) if the client communicates
with the server. This is expensive and doesn't make any sense to do for
the error we're trying to prevent here, forgetful developers that
forgotten to push a submodule.

A design goal for this check has been to make it just a client side
check.

I do not have a % value of how usual this fault is. I do know that
developers being introduced to submodules that I know of tends to
forget this (and so do I occasionally).

* According to what I found out. If there's a better solution I would of
  course be very happy.

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com