From: Steffen Daode Nurpmeso <sdaoden@googlemail.com>
Date: Tue, 28 Jun 2011 18:48:33 GMT
Subject: Re: [PATCH] progress: use \r as EOL only if isatty(stderr) is true
Message-ID: <20110628184833.GA385@sherwood.local>
In-Reply-To: <7vwrg5u7oz.fsf@alter.siamese.dyndns.org>

@ Junio C Hamano <gitster@pobox.com> wrote (2011-06-28 20:33+0200):
> [..]
> I thought that we try to disable the progress pretty much
> everywhere when we are not talking to a tty[..]

If Tay Ray Chuan would have Cc'd the list, too, i would have
thought he tried to draw attention onto the fact that this is
questionable design, if you allow me this comment.

It would indeed be more logical to simply "peek" onto progress and
let that decide on it's own wether it is useful or possible to
print any progress indication or not.

--
Ciao, Steffen
sdaoden(*)(gmail.com)
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments