From: Steffen Daode Nurpmeso <sdaoden@googlemail.com>
Date: Tue, 28 Jun 2011 18:04:39 GMT
Subject: Re: [PATCH] progress: use \r as EOL only if isatty(stderr) is true
Message-ID: <20110628180439.GA86588@sherwood.local>
In-Reply-To: <BANLkTinRe=pA=_obCmPKBjJMXH_pDfwCtw@mail.gmail.com>

@ Tay Ray Chuan <rctay89@gmail.com> wrote (2011-06-28 18:27+0200):
> hmm, shouldn't the onus of checking tty fall on to callers of
> progress* functions?

Ok, in the meanwhile i have understood what you ment, but
unfortunately i have thrown away the logfile which caused me to
write the patch, and even more unfortunately i could not reproduce
in the last hour or what any 'xy  ^Mxy  ^M' dump with the current
state of the repos.  A short 'git grep -F progress' is useless
from my current point of view (and with the amount of my free
time).  The script contains these git(1) related commands anyway:

    git pull -v --ff-only --stat --prune && git gc
    git svn rebase [not at the time of the log: && git gc]

But that is true: i have had a log file with the mentioned content.

--
Ciao, Steffen
sdaoden(*)(gmail.com)
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments