From: Jeff King <peff@peff.net>
Date: Tue, 28 Jun 2011 15:54:34 GMT
Subject: Re: [PATCH] rebase: do not print lots of usage hints after an obvious error message
Message-ID: <20110628155434.GA3747@sigill.intra.peff.net>
In-Reply-To: <4E09CD16.2040800@viscovery.net>

On Tue, Jun 28, 2011 at 02:46:14PM +0200, Johannes Sixt wrote:

> The error message was introduced recently by 4ac5356c (rebase: give a
> better error message for bogus branch, 2011-01-27), and the result was
> acceptable because the usage text was just two lines. But 45e2acf3
> (rebase: define options in OPTIONS_SPEC, 2011-02-28) made things worse
> because the usage text is now 35 lines.
> 
> Just drop the usage information because it does not add value to the
> error message.

Acked-by: Jeff King <peff@peff.net>

A git-sh-setup function to print just the summary bit of the usage would
restore the original behavior, but I agree it's not really adding
anything.

-Peff