From: Jeff King Date: Wed, 22 Jun 2011 01:22:20 GMT Subject: [PATCHv2 2/9] archive-tar: don't reload default config options Message-ID: <20110622012220.GB30604@sigill.intra.peff.net> In-Reply-To: <20110622011923.GA30370@sigill.intra.peff.net> We load our own tar-specific config, and then chain to git_default_config. This is pointless, as our caller should already have loaded the default config. It also introduces a needless inconsistency with the zip archiver, which does not look at the config files at all (and therefore relies on the caller to have loaded config). Signed-off-by: Jeff King --- Last time the tar-filter code was not integrated with the tar code. Since we are now under tar.*, and since the tar code reads the config anyway, it makes sense for us to use that config callback. This was just a little nit I noticed while changing it. archive-tar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/archive-tar.c b/archive-tar.c index cee06ce..1ab1a2c 100644 --- a/archive-tar.c +++ b/archive-tar.c @@ -231,7 +231,7 @@ static int git_tar_config(const char *var, const char *value, void *cb) } return 0; } - return git_default_config(var, value, cb); + return 0; } int write_tar_archive(struct archiver_args *args) -- 1.7.5.4.44.g4b107