From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 21 Jun 2011 17:04:17 GMT
Subject: Re: [PATCH 09/13] revert: Catch incompatible command-line options early
Message-ID: <20110621170416.GN15461@elie>
In-Reply-To: <1308661489-20080-10-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> Earlier, incompatible command-line options used to be caught in
> pick_commits after parse_args has parsed the options and populated the
> options structure.  Instead, hand over the responsibility of catching
> incompatible command-line options to parse_args so that the program
> can die early.

The "Earlier ... used to" phrasing is tripping me up again.

The naive reader (i.e., me) wonders: how long does this option parsing
and populating the options structure that we want to delay until after
verify_opt_compatible take?  Does that delay matter or is there some
other reason for this change?

> Also write a verify_opt_compatible function to handle
> incompatible options in a general manner.

Nitpick: the commit message generally commands the program or the
codebase to behave in a certain way, but in this example it is
commanding the author.  I'd say "add" or "provide".