From: Andi Kleen <ak@linux.intel.com>
Date: Tue, 21 Jun 2011 00:17:03 GMT
Subject: Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN
Message-ID: <20110621001703.GA700@alboin.amr.corp.intel.com>
In-Reply-To: <7v1uyoaxu5.fsf@alter.siamese.dyndns.org>

> When the above is applied and compiled without NO_NORETURN, the extra
> return may be optimized out by the compiler as your commit log messages
> said, but wouldn't it introduce a new warning:
> 
>   builtin/commit.c: In function 'find_author_by_nickname':
>   builtin/commit.c:965: error: will never be executed
> 
> under -Wunreachable-code?

It may, but that option isn't set for git?

-Andi