From: Johan Herland <johan@herland.net>
Date: Mon, 20 Jun 2011 07:41:54 GMT
Subject: Re: [PATCH 1/6] Bring notes.c template handling in line with commit.c.
Message-ID: <201106200941.54883.johan@herland.net>
In-Reply-To: <7vpqm9e8rn.fsf@alter.siamese.dyndns.org>

On Monday 20 June 2011, Junio C Hamano wrote:
> Johan Herland <johan@herland.net> writes:
> > On Saturday 18 June 2011, Yann Dirson wrote:
> >> Signed-off-by: Yann Dirson <ydirson@free.fr>
> > 
> > Please mention in the commit message that the commit merely replaces
> > write_or_die()/int fd with the corresponding stdio functionality, and
> > that there is no (intended) change in behavior. It was not apparent
> > from your commit message that you had not made any other changes.
> > 
> > Otherwise the patch looks OK.
> 
> I had an impression that you would lose a lot of error checking, unless
> you are careful, if you go from write_or_die() to stdio.

Yeah, write_or_die() dies on failure, while with fwrite/fprintf I guess one 
needs to check the return value, and handle errors accordingly.

An alternative solution would be to drop this patch, and instead use 
strbuf_addf() to get the format printing functionality needed in PATCH 3/6.


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net